feat: make array indexes polymophic integers #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
previously approved these changes
Jul 6, 2023
jfecher
approved these changes
Jul 6, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 7, 2023
* feat: make array indexes poly int * Update crates/noirc_frontend/src/hir/type_check/expr.rs * Update crates/noirc_frontend/src/hir/type_check/stmt.rs --------- Co-authored-by: jfecher <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* fix: workaround for #1838 This is currently not ideal in form but should inform a larger fix * fix: cargo check * Fix hacked path * Fix hacked path * Fix hacked path * feat: make array indexes polymophic integers (#1877) * feat: make array indexes poly int * Update crates/noirc_frontend/src/hir/type_check/expr.rs * Update crates/noirc_frontend/src/hir/type_check/stmt.rs --------- Co-authored-by: jfecher <[email protected]> * Make proving and verification keys optional * More merge progress * chore: introduce lib_hacky segregation --------- Co-authored-by: Álvaro Rodríguez <[email protected]> Co-authored-by: jfecher <[email protected]> Co-authored-by: kevaundray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Allows array accesses to use integers, which were disallowed in the frontend but supported by the backend.
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.